[MPlayer-dev-eng] [PATCH] UTF-8 osd messages

[Adam Tlałka]

On Fri, May 12, 2006 at 07:04:03PM +0200, Reimar Döffinger wrote:
> Hi,
> On Fri, May 12, 2006 at 11:24:36AM -0400, Rich Felker wrote:
> > > It may be better to commit the code then....
> > > Well, it's up to Reimar.
> > 
> > I consider this code to be bugfix code..
> 
> It might break when somebody compiles/configures with --charset=noconv
> or so, then our localizations are not in UTF8.
> Probably same for the bitmap fonts (at least I doubt they were all fixed to
> work with unicode).
> IOW, it has some shortcomings, I won't apply unless someone urges me to
> do it (or apply themselves).
> Somewhat related: I'd really prefer to make all the localized files UTF8
> instead of the current default, getting rid of the need for an iconv
> run for most compiles.

You have to use iconv in case of loading subtitle files or you must have
them already recoded to UTF-8. So iconv(3) will be used anyway or you
must force users to recode their subtitle files to get rid of iconv
from mplayer's code. So think carefully ;-).
Localized messages are not so bad but in case of non UTF-8 encoding
they simply should have some tag which indicates which encoding is used
inside. It is not a big problem IMHO.

Regards
-- 
Adam Tlałka       mailto:atlka at pg.gda.pl    ^v^ ^v^ ^v^
PGP public key:   finger atlka at sunrise.pg.gda.pl