[MPlayer-dev-eng] [PATCH] disable mediaLib by default and make test Solaris-only

[Ivan Kalvachev]

2006/5/12, Derek E. Lewis <dlewis at solnetworks.net>:
> mediaLib has been broken for quite awhile now on Solaris/SPARC in lavc,
> and will definitely not be fixed before pre8 is released.  Whenever a
> user encodes using lavc they get a 'thick' green-tint in the output
> file.  A similar event takes place when decoding.
>
> mediaLib provides no performance gains for x86 -- in reality, it does
> the opposite.  After doing some quick decoding benchmarks[1] between
> MPlayer binaries /w mediaLib  and w/o mediaLib, I calculated that
> MPlayer is 2.3x faster on Solaris/x86 if one disables mediaLib, which is
> not the default, now.
>
> I've also made mediaLib a Solaris-only test, and updated the ChangeLog
> to reflect this patch.
>
> Thanks,
>
> [1] Tests done using `matrixbench_highdivx_ac3.avi' in the testsuite and
> lavc for decoding.

It is ok to disable mlib by default if it is and always have been buggy.

Could you please aslo make sure that --enable-mlib would put _mlib to
"auto" not to "yes". This is the convention for disabled-by-default
options.

However, once option is disabled by default we must assume the user
knows that he is doing by explicitly enabling it again. Your way of
forcefully disabling mlib on non-Solaris is not acceptable in such
situation.