[MPlayer-dev-eng] [PATCH] screenshoot every frame

[Evgeniy Stepanov]

On Tuesday 09 May 2006 22:25, Attila Kinali wrote:
> >  	gen_fname(vf->priv);
> >  	if (vf->priv->fname[0]) {
> >  	    if (!vf->priv->store_slices)
> > @@ -225,8 +226,17 @@
> >
> >  int control (vf_instance_t *vf, int request, void *data)
> >  {
> > +    const int *const tmp = data;
>
> Just a nitpick, but why do you create another
> variable? Ok, const * const, but still.
> Beside giving it a generic name like "tmp" isn't
> a good idea.

To avoid casting later in the code. In this case it is not really needed.

I don't see much point in documenting vf_screenshot. It's really simple, and 
doesn't affect anything outside vf_screenshot.c.

Anyway, here is an updated patch. Is it ok now ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: screenshot-switch.patch
Type: text/x-diff
Size: 3977 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060510/7d3b6f75/attachment.patch>