[MPlayer-dev-eng] [PATCH] trivial signed/unsigned comparisons fix - spudec.c

Sun May 7 19:14:12 CEST 2006

On Friday, 05 May 2006 at 17:18, Rich Felker wrote:
> On Fri, May 05, 2006 at 10:42:45AM +0200, Pierre Lombard wrote:
> > Hi,
> > 
> > The attached patch fix some 'always false' tests by somewhat more
> > sensible, I guess.
> > 
> > unsigned int a => a<0 is always false
> 
> It would probably be better to fix the type of the vars instead of
> casting all over the place..

Agreed, I'll take a look.

R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan