[MPlayer-dev-eng] [PATCH] warning fix - libmpcodecs/vf_screenshot.c

Pierre Lombard p_l at gmx.fr
Fri May 5 10:46:20 CEST 2006


Hi,

Either the function returns values, either not.
I think 'not' seems to be what it was meant to return...


-- 
Pierre Lombard
GPG: 0x1AF0803C
-------------- next part --------------
Index: libmpcodecs/vf_screenshot.c
===================================================================
RCS file: /cvsroot/mplayer/main/libmpcodecs/vf_screenshot.c,v
retrieving revision 1.9
diff -u -r1.9 vf_screenshot.c
--- libmpcodecs/vf_screenshot.c	21 Mar 2006 21:26:42 -0000	1.9
+++ libmpcodecs/vf_screenshot.c	5 May 2006 08:38:28 -0000
@@ -54,7 +54,7 @@
     return vf_next_config(vf,width,height,d_width,d_height,flags,outfmt);
 }
 
-static int write_png(char *fname, unsigned char *buffer, int width, int height, int stride)
+static void write_png(char *fname, unsigned char *buffer, int width, int height, int stride)
 {
     FILE * fp;
     png_structp png_ptr;
@@ -69,13 +69,13 @@
     if (setjmp(png_ptr->jmpbuf)) {
 	png_destroy_write_struct(&png_ptr, &info_ptr);
 	fclose(fp);
-	return 0;
+	return;
     }
 
     fp = fopen (fname, "wb");
     if (fp == NULL) {
 	mp_msg(MSGT_VFILTER,MSGL_ERR,"\nPNG Error opening %s for writing!\n", fname);
-	return 0;
+	return;
     }
         
     png_init_io(png_ptr, fp);


More information about the MPlayer-dev-eng mailing list