[MPlayer-dev-eng] [PATCH] if(verbose>X) --> mp_msg_test

[Reynaldo H. Verdejo Pinochet]

On Wed, Mar 29, 2006 at 07:08:05PM +0200, Ötvös Attila wrote:
> 2006. március 27. 10.00 dátummal Diego Biurrun ezt írta:
> > On Sun, Mar 26, 2006 at 10:23:46PM +0200, Ötvös Attila wrote:
> > liba52 should not be patched, it's an imported library, there is still
> > one if (verbose) in vf_tile.c that you removed.  I've fixed the
> > remaining if(verbose) calls.
> liba52 removed
> vf_tile modify
> 
> > Other than that the patch looks OK at a quick glance. It should probably
> > be applied piece by piece to make review easier unless somebody jumps in
> > and reviews it as a whole.
> 
> I separate patch to files and updated with CVS.
> 

Ok Otvos, Im commiting your changes with minor corrections, just a
quick advice Im sure your future reviewers will appreaciate:

when facing the need of spliting a big patch into smaller units, the
important thing is to make sure each unit can be applied separately,
there is no point of making 30 patches that can only be applyed all
together.

Thanks again for your time and work.

Best regards

  Reynaldo  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060330/8b93d0a9/attachment.pgp>