[MPlayer-dev-eng] [PATCH] if(verbose>X) --> mp_msg_test

Reynaldo H. Verdejo Pinochet reynaldo at opendot.cl
Thu Mar 30 08:38:04 CEST 2006


On Wed, Mar 29, 2006 at 11:53:59PM -0400, Reynaldo H. Verdejo Pinochet wrote:
> On Wed, Mar 29, 2006 at 01:27:00PM +0200, Diego Biurrun wrote:
> > On Mon, Mar 27, 2006 at 10:00:45AM +0200, Diego Biurrun wrote:
> > > 
> > > I've ripped out and applied the printf --> fprintf part to get things
> > > started.
> > > 
> > > liba52 should not be patched, it's an imported library, there is still
> > > one if (verbose) in vf_tile.c that you removed.  I've fixed the
> > > remaining if(verbose) calls.
> > > 
> > > Other than that the patch looks OK at a quick glance. It should probably
> > > be applied piece by piece to make review easier unless somebody jumps in
> > > and reviews it as a whole.
> > 
> > Reynaldo, can you look into this?  Probably it's easiest to split the
> > patch in pieces and review/apply them separately, it's quite large.
> > 
> > Diego
> 
> No prob, sorry for the delay.
> 
>   Reynaldo

Ok Im reviewing fixing and commiting his changes in small parts, Im 
almost sure they could still have gram and sintax errors but imho they
can be easily fixed once in the codebase.

I think this is the right aproach, hope is ok.

  Reynaldo




> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060330/541fe620/attachment.pgp>


More information about the MPlayer-dev-eng mailing list