[MPlayer-dev-eng] [PATCH] if(verbose>X) --> mp_msg_test

Diego Biurrun diego at biurrun.de
Mon Mar 27 10:00:45 CEST 2006


On Sun, Mar 26, 2006 at 10:23:46PM +0200, Ötvös Attila wrote:
> 2006. március 26. 11.47 dátummal Diego Biurrun ezt írta:
> > > At a first glance: Please structure your additions to help_mp-en.h a
> > > bit, i.e. add comments describing to which files the messages belong
> > > like it's done in the rest of the file.
> >
> > At a second glance: MSGL_V and above messages need not be translated as
> > they are only debug output intended for developers, so they should not
> > be moved to help_mp-en.h.
> 
> Add #include "help_mp.h"
> Remove MSGTR_LIBVO_SdlMode
> Add c file name to help_mp-en.h in comment.

I've ripped out and applied the printf --> fprintf part to get things
started.

liba52 should not be patched, it's an imported library, there is still
one if (verbose) in vf_tile.c that you removed.  I've fixed the
remaining if(verbose) calls.

Other than that the patch looks OK at a quick glance. It should probably
be applied piece by piece to make review easier unless somebody jumps in
and reviews it as a whole.

Diego




More information about the MPlayer-dev-eng mailing list