[MPlayer-dev-eng] Debian build fails with new Makefiles

[Corey Hickey]

Dominik 'Rathann' Mierzejewski wrote:
> On Sunday, 26 March 2006 at 21:48, Corey Hickey wrote:
>> Stone wrote:
>>> On 2006-03-25, there were changes checked into main that broke the Debian
>>> build scripts.  Does anyone have a solution?
>>>
>>> make[1]: Entering directory `/var/local/mplayer.cvs/main'
>>> /usr/bin/make -C libdha install
>>> make[2]: Entering directory `/var/local/mplayer.cvs/main/libdha'
>>> mkdir -p /var/local/mplayer.cvs/main/debian/mplayer/usr/lib
>>> install -m 755  -p libdha.so.1.0
>>> /var/local/mplayer.cvs/main/debian/mplayer/usr/lib/libdha.so.1.0
>>> rm -f /var/local/mplayer.cvs/main/debian/mplayer/usr/lib/libdha.so
>>> ln -sf libdha.so.1.0
>>> /var/local/mplayer.cvs/main/debian/mplayer/usr/lib/libdha.so.1
>>> ldconfig
>>> make[2]: ldconfig: Command not found
>>> make[2]: *** [install] Error 127
>>> make[2]: Leaving directory `/var/local/mplayer.cvs/main/libdha'
>>> make[1]: *** [install] Error 2
>> Hmm, you're right. Looks like that would break for any non-root 
>> installation. Try out the attached patch.
>>
>> Diego, if you see this:
>> Can I apply the patch or is there a better way to do it? I don't know 
>> Makefiles well.
>>
>> -Corey
> 
>> Index: libdha/Makefile
>> ===================================================================
>> RCS file: /cvsroot/mplayer/main/libdha/Makefile,v
>> retrieving revision 1.28
>> diff -u -r1.28 Makefile
>> --- libdha/Makefile	25 Mar 2006 10:38:36 -0000	1.28
>> +++ libdha/Makefile	26 Mar 2006 19:43:11 -0000
>> @@ -86,19 +86,23 @@
>>  	install -m 755 $(INSTALLSTRIP) -p $(LIBNAME) $(LIBDIR)/$(LIBNAME)
>>  	rm -f $(LIBDIR)/libdha.so
>>  	ln -sf $(LIBNAME) $(LIBDIR)/$(SHORTNAME)
>> +ifeq ($(USER),root)
>>  ifeq ($(TARGET_OS),OpenBSD)
>>  	ldconfig -R
>>  else
>>  	ldconfig
>>  endif
>> +endif
>>  
>>  uninstall:
>>  	rm -f $(LIBDIR)/libdha.so $(LIBDIR)/$(SHORTNAME) $(LIBDIR)/$(LIBNAME)
>> +ifeq ($(USER),root)
>>  ifeq ($(TARGET_OS),OpenBSD)
>>  	ldconfig -R
>>  else
>>  	ldconfig
>>  endif
>> +endif
>>  
>>  #
>>  # include dependency files if they exist
> 
> 
> Is this the correct fix? Is ldconfig supposed to be in $PATH on all
> OSes? Why not just use /sbin/ldconfig?

bugfood at fire:~$ /sbin/ldconfig
/sbin/ldconfig: Can't create temporary cache file /etc/ld.so.cache~: 
Permission denied

I don't know if this is universally true, but at least on Debian there's 
only one default ld cache for all users, and it's owned by root.

-Corey