[MPlayer-dev-eng] [PATCH] if(verbose>X) --> mp_msg_test

[Reynaldo H. Verdejo Pinochet]

On Sun, Mar 26, 2006 at 11:47:07AM +0200, Diego Biurrun wrote:
> On Sun, Mar 26, 2006 at 11:43:40AM +0200, Diego Biurrun wrote:
> > On Sun, Mar 26, 2006 at 11:41:21AM +0200, Ötvös Attila wrote:
> > > 2006. március 24. 20.18 dátummal Diego Biurrun ezt írta:
> > > > On Fri, Mar 24, 2006 at 08:11:38PM +0100, Ötvös Attila wrote:
> > > > >
> > > > > Shall I update my printf patch?
> > > >
> > > > Yes, please.
> > > I updated.
> > 
> > At a first glance: Please structure your additions to help_mp-en.h a
> > bit, i.e. add comments describing to which files the messages belong
> > like it's done in the rest of the file.
> 
> At a second glance: MSGL_V and above messages need not be translated as
> they are only debug output intended for developers, so they should not
> be moved to help_mp-en.h.
> 
> Diego

Sad I didnt noticed it earlier :( may the comment on mp_msg.h be more
clear about this?

 Reynaldo
-------------- next part --------------
Index: mp_msg.h
===================================================================
RCS file: /cvsroot/mplayer/main/mp_msg.h,v
retrieving revision 1.38
diff -a -u -r1.38 mp_msg.h
--- mp_msg.h	24 Mar 2006 01:32:04 -0000	1.38
+++ mp_msg.h	26 Mar 2006 20:21:05 -0000
@@ -8,7 +8,7 @@
 
 // verbosity elevel:
 
-// stuff from level MSGL_FATAL-MSGL_STATUS should be translated.
+// only stuff from level MSGL_FATAL-MSGL_STATUS should be translated.
 
 #define MSGL_FATAL 0  // will exit/abort
 #define MSGL_ERR 1    // continues
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060326/5c2cc3f4/attachment.pgp>