[MPlayer-dev-eng] [PATCH] correct mp3lib -v output on PPC

[Alexander Strange]

On Mar 26, 2006, at 5:31 AM, Diego Biurrun wrote:
>
> --- mp3lib/sr1.c	9 Feb 2006 14:08:00 -0000	1.36
> +++ mp3lib/sr1.c	24 Mar 2006 00:30:43 -0000
> @@ -447,6 +447,14 @@
>      }
>      else
>  #endif
> +#ifdef HAVE_ALTIVEC
> +    if (gCpuCaps.hasAltiVec)
> +    {
> +	synth_func = NULL; /* only dct64 is altivec-optimized; it uses  
> the C synth_func */
> +	mp_msg(MSGT_DECAUDIO,MSGL_V,"mp3lib: using AltiVec optimized  
> decore!\n");
> +    }
> +    else
> +#endif
>      {
>  	synth_func = NULL; /* use default c version */
>  	mp_msg(MSGT_DECAUDIO,MSGL_V,"mp3lib: using generic C decore!\n");
>
> Why is it necessary to set synth_func to NULL?

Right now it's declared undefined. It seemed like it would be against  
the patching guidelines to have this change more code by making it  
set to NULL in the first place, but I can do that if you want.