[MPlayer-dev-eng] Re: [PATCH] vidix makefile and paralle build

[Alban Bedel]

On Sun, 26 Mar 2006 10:54:34 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Sun, Mar 26, 2006 at 08:54:23AM +0200, Alban Bedel wrote:
> > On Sun, 26 Mar 2006 00:07:49 +0100
> > Alban Bedel <albeu at free.fr> wrote:
> > 
> > > their is a little quirk in the vidix Makefile that make parelle build
> > > suboptimal. First problem is the DO_MAKE macro, it call make on all subdirs.
> > > The problem is that this is done in a shell loop, so make can't detect that
> > > the job is another make. As their is only one subdir that macro seem pretty
> > > useless, so i simply removed it.
> > > Another pb is the 'all' rule where DO_MAKE is used as target preventing
> > > building the library and the drivers in parallel. The patch add an
> > > extra rule to build the drivers and put it as prerequisite for "all".
> > > The same thing could be done for the other rules but it's probably
> > > not really worse the kludge in the makefile.
> > 
> > And their is a nice 10L in the previous patch. The 'all' rule should stay
> > the first one, here is a corrected patch.
> 
> There is more than just one kludge in the MPlayer build system...

Probably :/ I noticed this bcs make complain the jobserver is not available
when entering the drivers subdir.

> Have you looked at the top-level Makefile as well?  DO_MAKE is called
> from there as well, since you remove DO_MAKE, you will have to adapt it.

I removed it only from the vidix Makefile, that won't change a thing for
the other Makefiles. In the top-level Makefile it is defined again,
but it's used only for un/install so that's not critical even if it is
quiet bad style.

	Albeu