[MPlayer-dev-eng] [PATCH] OSD tinting for vo_gl

[Arpi]

Hi,

> This is a multi-part message in MIME format.
> 
> Hello,
> my friend asked me if it's possible to change the OSD color. I found 
> that the osd is stored in greyscale, so I wrote a tinting patch for one 
> particular vo. Maybe someone is interested in it.
> 
> Greetings,

> +  } else {
> +    int i;
> +    char *tmp = (char *)malloc(stride * h * 3);
> +    for (i = 0; i < h * stride; i++) {
> +      tmp[i*3] = src[i] * ((osd_color & 0xff0000) >> 16) / 255;
> +      tmp[i*3+1] = src[i] * ((osd_color & 0xff00) >> 8) / 255;
> +      tmp[i*3+2] = src[i] * (osd_color & 0xff) / 255;
> +    }

argh, such hacks should not go into the vo drivers...

i really believed (before looking at the patch) you implemented it in
the opengl driver because you can use opengl's colorizing/lighting
features for this...


A'rpi