[MPlayer-dev-eng] [PATCH] Add window icon to x11-based vo

[Guillaume POIRIER]

Hi,
the attached patch implement $subj.
It's basically a rip-off of Danny Milosavljevic's patch sent to thread:
Date: Feb 12, 2006 6:59 PM
Subject: [MPlayer-dev-eng] window title patch

... except this patch only adds the icon, and doesn't change the
title, and the actual icon used is the official icon of MPlayer.

Please direct all flames to /dev/null [either you do it or I do it on
my machine ;o)] and tell how this patch can be improved, or if it
deserves to be merged on CVS.

One of the things that aren't too good about that patch is the fact
that the xpm icon has been directly generated with imagemagik, so it's
quite possible that it may be overly big or that some obscure plate
forms will choke on it.
One of the other things that isn't too great is that it adds a
dependency on libxpm (which means that you need to append "-lXpm" to
the build command line to test this patch)... and I know we don't like
to add additional dependencies if possible. So maybe it could be a
better idea to load the icon with libpng if MPlayer has been compiled
with png support? I don't know how easy this could be, but I'm sure
it's feasible.

Thoughts?

Guillaume
Please keep Danny in CC as he's the author of this patch, and he is
not subscribed.
--
I am disillusioned enough to know that no man's opinion on any subject
is worth a damn unless backed up with enough genuine information to
make him really know what he's talking about.

-- H. P. Lovecraft (about the flamewars on FFmpeg and MPlayer-dev mailing lists)
http://www.brainyquote.com/quotes/quotes/h/hplovecr278144.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: display_mplayer_icon.patch
Type: text/x-patch
Size: 11484 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060323/0f9a9c6b/attachment.bin>