[MPlayer-dev-eng] [PATCH] if(verbose>X) --> mp_msg_test

[Reynaldo H. Verdejo Pinochet]

On Thu, Mar 23, 2006 at 10:38:00AM +0100, Diego Biurrun wrote:
> On Wed, Mar 22, 2006 at 12:53:37AM +0100, Diego Biurrun wrote:
> > 
> > I've converted
> > the proper way and gets us rid of a few global vars as an added bonus.
> 
> Forgot to mention: There are some 'if (verbose > 4)' calls, for which I
> would have to add something like the following:
> 
> --- mp_msg.h    9 Feb 2006 14:07:52 -0000       1.37
> +++ mp_msg.h    23 Mar 2006 09:36:14 -0000
> @@ -20,6 +20,7 @@
>  #define MSGL_DBG2 7   // v=2
>  #define MSGL_DBG3 8   // v=3
>  #define MSGL_DBG4 9   // v=4
> +#define MSGL_DBG5 10  // v=5

Seems ok but I wonder if we really need so many DBG levels, are there
any rules on how to decide wich DBGX to use? if there arent this may be 
the right time to make some.

> 
> Anything I overlooked?  Otherwise I will doublecheck and commit tonight
> or so.
> 

Looks ok.

> Diego

Best regards

   Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060323/aee65055/attachment.pgp>