[MPlayer-dev-eng] [PATCH] printf -> mp_msg
Diego Biurrun
diego at biurrun.de
Tue Mar 21 18:43:16 CET 2006
On Tue, Mar 21, 2006 at 11:29:24AM -0400, Reynaldo H. Verdejo Pinochet wrote:
> On Tue, Mar 21, 2006 at 08:48:24AM +0100, Diego Biurrun wrote:
> > On Tue, Mar 21, 2006 at 12:27:42AM +0100, Ötvös Attila wrote:
> > > 2006. március 20. 23.05 dátummal Diego Biurrun ezt írta:
> > > > On Mon, Mar 20, 2006 at 10:41:07PM +0100, Ötvös Attila wrote:
> > > > > I cosmetics printf patch:
> > > > > - standartized modul name eg: [LIBA52]
> > > > > - upper case first char in sentence
> > > > > - closed sentence with point "."
> > > >
> > > > You still have removed the if(verbose) conditionals in places. This is
> > > > not correct. I have just made a patch that replaces them by mp_msg_test
> > > > calls. I'll just commit it before your patch goes in.
> > >
> > > I remove if(verbose) but still some places.
> >
> > They are still in some places. Don't worry about it, though, I'll have
> > them replaced in a few days anyway.
>
> Ok to commit after already asked corrections then?
No, the patch in its current form is wrong. Please let this matter rest
until I have committed my mp_msg_test changes. I have finished
implementing this yesterday, but I need to double-check my changes
before committing, I'm sure there are still a few hidden 10l typos
inside.
Diego
More information about the MPlayer-dev-eng
mailing list