[MPlayer-dev-eng] [PATCH]ffmp3 inited sample_rate problem

[Rich Felker]

On Tue, Mar 21, 2006 at 12:37:58PM +0100, Michael Niedermayer wrote:
> Hi
> 
> On Mon, Mar 20, 2006 at 01:46:18PM +0100, Diego Biurrun wrote:
> > On Sun, Mar 19, 2006 at 10:26:07AM +0800, qwen dux wrote:
> > > I find
> > > http://www.mplayerhq.hu/MPlayer/samples/avi/ffmp3_bad_rate_detection.avi
> > >  was also decoded by ffmp3 by mistake,Is there a same error have been found
> > > by somebody before me?my samples is too big,so i can't upload the ftp
> > > server.
> > 
> > That sample is indeed fixed by your patch.  Michael?
> 
> if the change doesnt break anything then iam fine with it

Basically this patch seems to be "trust the demuxer instead of the
decoder" which is a philosophy I generally agree with. However, in the
future it might be good to make this a user option for all
demuxers/codecs, with the default depending on the demuxer (and in
some really broken cases also on the codec). IIRC quicktime sometimes
stores total nonsense in the demuxer headers. :)

Rich