[MPlayer-dev-eng] [PATCH] printf -> mp_msg

Ötvös Attila oattila at chello.hu
Tue Mar 21 00:27:42 CET 2006


2006. március 20. 23.05 dátummal Diego Biurrun ezt írta:
> On Mon, Mar 20, 2006 at 10:41:07PM +0100, Ötvös Attila wrote:
> > I cosmetics printf patch:
> > - standartized modul name eg: [LIBA52]
> > - upper case first char in sentence
> > - closed sentence with point "."
>
> You still have removed the if(verbose) conditionals in places.  This is
> not correct.  I have just made a patch that replaces them by mp_msg_test
> calls.  I'll just commit it before your patch goes in.

I remove if(verbose) but still some places. 
Example:
--- libmpdemux/demux_asf.c	2006-02-17 02:57:40.000000000 +0100
+++ libmpdemux/demux_asf.c	2006-03-20 23:13:18.000000000 +0100
@@ -180,8 +180,8 @@
             
             if(verbose>1){
                 int i;
-                for(i=0;i<16;i++) printf(" %02X",asf_packet[i]);
-                printf("\n");
+                for(i=0;i<16;i++) mp_msg(MSGT_DEMUX,MSGL_V,
"%02X",asf_packet[i]);
+                mp_msg(MSGT_DEMUX,MSGL_V,"\n");
             }
             
 	    // skip ECC data if present by testing bit 7 of flags

Best regards!
Attila
-------------- next part --------------
A non-text attachment was scrubbed...
Name: printf_4.patch.gz
Type: application/x-gzip
Size: 44368 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060321/4317728f/attachment.bin>


More information about the MPlayer-dev-eng mailing list