[MPlayer-dev-eng] [PATCH] printf -> mp_msg

[Ötvös Attila]

2006. március 20. 22.02 dátummal The Wanderer ezt írta:
> (If such a change *is* made, incidentally, I would recommend extending
> the MSGTR to MSGTR_LIBMENU_MemAllocError - rather than just capitalizing
> the A - for consistency with the example you gave.)
>
> > * Check phrasing on this ones:
> >
> > MSGTR_LIBMENU_MenuTxtNeedATxtFileName "Menu txt need a txt file name
> > (param file)\n" (sounds weird)

Don't settings text file name in menu.conf. 
Example:
<txt name="man" file="manpage.txt">


> Very. I have no idea what it even *means*, so I can't really try to
> rephrase it. Is it talking about a file called "menu.txt", or does it
> want the word "text" there, or is there something I haven't thought of?
>
> In any case, instead of "txt file", it should be either "text file" or
> ".txt file".
>
> > MSGTR_LIBMENU_MenuTxtCantOpen "Menu txt can't open: %s\n" (sounds weird)
>
> Same problem here, I don't know what it means.
>
> > MSGTR_LIBMENU_WarningTooLongLineSplitting "Warning too long
> > line, splitting it\n" (Warning, string too long, splitting it ?)
>
> Both forms have comma issues, and yes, "too long" should come after the
> noun rather than before. The comma issues could be avoided perhaps most
> simply by replacing the latter with an emdash, of whatever form is
> preferred.

I can't do. I am sorry to say that my English knowledge isn't good.

I cosmetics printf patch:
- standartized modul name eg: [LIBA52]
- upper case first char in sentence
- closed sentence with point "."

Best regards!
Attila
-------------- next part --------------
A non-text attachment was scrubbed...
Name: printf_3.patch.gz
Type: application/x-gzip
Size: 44347 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060320/2467e805/attachment.bin>