[MPlayer-dev-eng] [PATCH] printf -> mp_msg

[Reynaldo H. Verdejo Pinochet]

On Sun, Mar 19, 2006 at 11:34:00PM +0100, Diego Biurrun wrote:
> On Sun, Mar 19, 2006 at 07:24:37PM +0100, Ötvös Attila wrote:
> > 
> > liba52: 
> > parse.c, ao_oss.c, ao_sun.c, audio_out.c
> 
> This is an imported library, don't patch it.
> 
> You have a few hunks like the following in the patch:
> 
> -    if(verbose > 4)
> -        printf("vd_ffmpeg::mc_get_buffer\n");
> +//    if(verbose > 4)
> +        mp_msg(MSGT_DECVIDEO, MSGL_DBG4, "vd_ffmpeg::mc_get_buffer\n");
> 
> Somebody correct me if I am wrong, but I believe this is incorrect,
> since now the call to mp_msg will not be skipped as it should.
> 
> Diego

I prefer the later, having if(verbose >|<|= X) clauses _and_ MSGL_X
is just error prone, duplicated work and useles code polution IMHO.

Best regards

  Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060319/1644cefd/attachment.pgp>