[MPlayer-dev-eng] Re: [PATCH] Use stream to read text subs

[Alban Bedel]

On Thu, 16 Mar 2006 11:52:59 -0500
Rich Felker <dalias at aerifal.cx> wrote:

> On Thu, Mar 16, 2006 at 05:36:24PM +0100, Alban Bedel wrote:
> > On Thu, 16 Mar 2006 17:15:49 +0100
> > Tomas Janousek <tomi at nomi.cz> wrote:
> > 
> > > Hello,
> > > 
> > > Alban Bedel napsal(a):
> > > > Any comments, suggestions ? Some small testing would also be
> > > > welcome :)
> > > 
> > > It breaks compilation with LIVE555 libs. Patch attached.
> > 
> > Huh ? That doesn't seems needed to me, memchr() return void*. Or is
> > LIVE555 overridding the definiton of memchr ? The patch is ok, but i
> > really like to know why it is needed at all.
> 
> It's because MPlayer *still* (ARRRGGGGGGGG!!!!!!!) has crappy C++ code
> for live555 which includes these headers, and C++ is idiotic about how
> it handles void *. When will nemesi support be finished so we can
> remove that legacy junk??

Haa C++, don't we all love the shit. Anyway patch applied.

	Albeu