[MPlayer-dev-eng] [PATCH] disable filters that depend on dsputil.h

[Rich Felker]

On Tue, Mar 14, 2006 at 02:09:05PM +0200, Ivan Kalvachev wrote:
> 2006/3/14, Nico Sabbi <nicola_sabbi at fastwebnet.it>:
> > Hi,
> > last months we added dsputil.h to the install target of libavcodec;
> > it was a mistake because that file is not supposed to be used outside of
> > libavcodec.
> >
> > This patch disables the inclusion of filters that depend on that header
> > when libavcodec
> > is not imported in main/; if applied I'll post a patch to ffmpeg-devel
> > to restore the previous
> > behaviour (not install dsputil.h).
> >
> > Please, review.
> 
> I'm afraid this could be considered feature removal.
> The reason (interface purity) doesn't justify the result.
> 
> However I am not against conditional compilation of these filters.
> This includes ./configure detection of dsputil.h presence and check
> for called functions availability.

It's not feature removal because the feature is still there if you
compile with (the only supported way) internal lavc.

Rich