[MPlayer-dev-eng] [PATCH] disable filters that depend on dsputil.h

Ivan Kalvachev ikalvachev at gmail.com
Tue Mar 14 13:09:05 CET 2006


2006/3/14, Nico Sabbi <nicola_sabbi at fastwebnet.it>:
> Hi,
> last months we added dsputil.h to the install target of libavcodec;
> it was a mistake because that file is not supposed to be used outside of
> libavcodec.
>
> This patch disables the inclusion of filters that depend on that header
> when libavcodec
> is not imported in main/; if applied I'll post a patch to ffmpeg-devel
> to restore the previous
> behaviour (not install dsputil.h).
>
> Please, review.

I'm afraid this could be considered feature removal.
The reason (interface purity) doesn't justify the result.

However I am not against conditional compilation of these filters.
This includes ./configure detection of dsputil.h presence and check
for called functions availability.




More information about the MPlayer-dev-eng mailing list