[MPlayer-dev-eng] last printf in libaf

[Diego Biurrun]

On Mon, Mar 13, 2006 at 11:15:23PM -0800, Corey Hickey wrote:
> Reynaldo H. Verdejo Pinochet wrote:
> > +
> > +#define MSGTR_AF_FORMAT_UnknownSpecial "Unknown special\n"
> 
> My first thought was, "what does that mean?" I took a look at the code,
> and thought saying "unknown format" or maybe "unknown special format"
> would be better.
> 
> Then, I saw that it's in af_fmt2str(), which looks like it converts a
> numeric format into a string for human consumption. Wouldn't it be
> better to use snprintf() to put that message into the string so it gets
> printed in the proper context?
> 
> I would prefer the attached patch.
> 
> 
> Right now we would get something like:
> ...
> Unknown special
> alsa-init: format little-endian not supported by hardware, trying default
> ...
> 
> Using snprintf() would give us something like this:
> ...
> alsa-init: format little-endian unknown-format not supported by
> hardware, trying default
> ...

Please commit, this is a huge improvement..

Diego