[MPlayer-dev-eng] Re: [PATCH] QuickTime in24 and in32 PCM audio support

[Dominik 'Rathann' Mierzejewski]

On Monday, 13 March 2006 at 01:50, Dominik 'Rathann' Mierzejewski wrote:
> On Sunday, 12 March 2006 at 02:41, Baptiste COUDURIER wrote:
> > Hi,
> > 
> > Dominik 'Rathann' Mierzejewski wrote:
> > > [...]
> > > 
> > > Indeed. So with my patch, BE samples play fine, but LE (obviously) don't.
> > > Any idea how to tell one from another? The FourCC is the same.
> > 
> > Endianness is specified through 'enda' atom in MOV container. The change
> > needs to be done in the MOV demuxer.
> 
> Here's a preliminary, non-working patch (crashes). I couldn't make heads or tails
> of the fact that gdb tells me that trak is unset (NULL) here:
[...]
> Attached. Basically the idea is to byteswap the fourcc if enda atom says
> the PCM data is little-endian (enda->littleEndian==true) in demux_mov.c and
> then detect the swapped fourcc in ad_pcm.c.

Committed a fixed version. Tested on LE and BE machines by me and Diego.
Supports in24/in32/fl32 in LE and BE modes.
fl64 still doesn't work, but it can be fixed later.

R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and oppression
to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan