[MPlayer-dev-eng] Re: [PATCH 2/11] MPlayer <-> GeeXboX patches port : libmenu joystick support

[Alban Bedel]

On Sat, 11 Mar 2006 14:19:34 +0100
Benjamin Zores <ben at geexbox.org> wrote:

> On Fri, 24 Feb 2006 16:10:19 +0100
> Benjamin Zores <ben at geexbox.org> wrote:
> 
> > 
> > This patch allows libmenu to be controlled through Joystick.
> > 
> 
> Any chance of having it commited ?

Not as is. The idea is good but i don't like the implementation. Having
one callback per key type input is not good, this should be done in a
more generic way.
Sadly i can't test atm (no joystick at hand) but normaly key release
event should be propageted to the menu. Beside adding the keycodes to
menu.c i don't really see the point of the rest, but their is probably a
good reason. Could you perhaps explain a bit more why you did things
this way ?

	Albeu