[MPlayer-dev-eng] [BUG?][PATCH] af_equalizer too quiet

[Corey Hickey]

Reynaldo H. Verdejo Pinochet wrote:
>>I noticed that mplayer -af equalizer reduces the volume significantly.
>>Consider this command:
>>
>>$ mplayer file.mp3 -af equalizer
>>
>>(this corresponds to -af equalizer=0:0:0:0:0:0:0:0:0:0)
>>
>>Since the suboptions accept a range from -12 to 12 and 0 is the default,
>>I would expect 0 to be the neutral position and to have no effect on the
>>audio. Instead, the volume is reduced by a factor of 40 by line 193 of
>>af_equalizer.c:
>>
>>*out=yt/(4.0*10.0);
>>
>>Is that a bug? If so, the attached patch fixes it.
>>
>>-Corey
> 
> 
> Ok, new patch made with the help of Benjamin Larsson. should take
> care of avoiding the atenuation of unamplified signals and clipping 
> when filtered output exceds dinamic range. please test, I will
> apply this patch soon if no one complains.

Well, it certainly seems just fine to me. The neutral configuration
leaves the audio the same volume, and increasing the parameters doesn't
make it way too loud. I like it.

Thank you. :)

-Corey