[MPlayer-dev-eng] [PATCH] remove limits from af_equalizer
Reynaldo H. Verdejo Pinochet
reynaldo at opendot.cl
Sat Mar 11 00:28:13 CET 2006
On Fri, Mar 03, 2006 at 02:46:07PM -0800, Corey Hickey wrote:
>
> Ah, nice! I'm looking forward to seeing what you find out.
>
> -Corey
Well, see my last patch on 'af equalizer too quiet' thread. the reason
behind the atenuation factor we removed with your patch a few months
ago was to avoid clipping on the filtered output, that factor was
a harcoded value not a run time calculated one, leading to issues like
the one you observed when the filter lowered the level of a supossedly
unfiltered signal (-af equalizer=0:0:0....). When we dropped that
'atenuation' factor the filter started to clip wildly even with sane
db values (0-5), not a good behavior. I suppose we can share the cola
for that one ;)
Ok, the new patch resurrects the 'attenuator' factor but uses
a dinamic approach to calculate it at runtime starting at 1db when
the max gain over all bands is > 0. hope you like the results, as
far as my ears can tell it works a lot better.
Best regards
Reynaldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060310/094ca8d7/attachment.pgp>
More information about the MPlayer-dev-eng
mailing list