[MPlayer-dev-eng] [PATCH] [RFC] rename default skin directory

[Dominik 'Rathann' Mierzejewski]

On Monday, 06 March 2006 at 11:19, Diego Biurrun wrote:
> On Mon, Mar 06, 2006 at 11:50:47AM +0200, Ivan Kalvachev wrote:
> > 2006/3/4, Diego Biurrun <diego at biurrun.de>:
> > >
> > > I've always disliked the fact that gmplayer looks in subdirectories
> > > named 'Skin' for skins.  Capitalized names feel very non-Unixish to me
> > > and it's a bit misleading as well, since the directory can contain
> > > multiple skins and not just one.
> > >
> > > So the attached patch changes this behavior in a backwards-compatible
> > > fashion.  It's not very elegant, but tested to work.
> > >
> > > Comments, thoughts?
> > 
> > There is no need to preserve backward compablility. If you want to,
> > then at make isntall make symlink skin to Skin.
> 
> Well, I can make a symlink for the system-wide skins directory, but
> surely not inside ~/.mplayer/, a make install should not fiddle with a
> user's individual configuration IMO.

I tend to agree with Ivan here that the patch adds complexity to the code
and preserving backwards compatibility is not worth it, but I'm also
inclined to let it pass provided it is removed before the next release
(1.0pre9/1.0) latest.

R.

-- 
MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/
There should be a science of discontent. People need hard times and oppression
to develop psychic muscles.
	-- from "Collected Sayings of Muad'Dib" by the Princess Irulan