[MPlayer-dev-eng] [PATCH] libmpdemux/aviprint.c printf --> mp_msg

[Diego Biurrun]

On Sun, Mar 05, 2006 at 07:59:40AM +0200, Oded Shimon wrote:
> On Sat, Mar 04, 2006 at 07:39:08PM +0100, Diego Biurrun wrote:
> > 
> > While cleaning up some of the trees I have lying around I stumbled
> > across this printf to mp_msg conversion I had done a long time ago.  Are
> > the MSGT_ and MSGL_ I chose OK?
> 
> Doesn't everything here belong in MSGL_V, not MSGL_INFO ?... They are only 
> printed when using -v, because there's a 'if (verbose > 0)' check (which 
> should be changed in mp_msg_test() ).

Yes, after grepping through the code and finding out that mp_msg_test is
hardly used at all, it should probably changed in various places.  Are
you volunteering? :)

I used MSGL_V at first but then I switched to MSGL_INFO because the call
to the functions is guarded by if (verbose > 0) anyway.  So if I used
MSGL_V the functions would not output anything if called in non-verbose
mode (for whatever strange reason).

Diego