[MPlayer-dev-eng] [PATCH] libmpdemux/aviprint.c printf --> mp_msg

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Mar 5 12:23:37 CET 2006


Hi,
On Sun, Mar 05, 2006 at 07:59:40AM +0200, Oded Shimon wrote:
> On Sat, Mar 04, 2006 at 07:39:08PM +0100, Diego Biurrun wrote:
> > While cleaning up some of the trees I have lying around I stumbled
> > across this printf to mp_msg conversion I had done a long time ago.  Are
> > the MSGT_ and MSGL_ I chose OK?
> 
> Doesn't everything here belong in MSGL_V, not MSGL_INFO ?... They are only 
> printed when using -v, because there's a 'if (verbose > 0)' check (which 
> should be changed in mp_msg_test() ).

These are called at multiple places I think. Maybe the function should
just get a verbosity parameter that will be used?

Greetings,
Reimar Döffinger




More information about the MPlayer-dev-eng mailing list