[MPlayer-dev-eng] [PATCH] Adding Radio support to MPlayer (update)

Benjamin Zores ben at geexbox.org
Fri Jun 30 09:49:25 CEST 2006


> Hi, All
>
> Here is another updated version of radio patch.
> Fixed wrong return value in grab_audio_frame.
>
>
> And what about adding it into MPlayer?
> I wrote first email about week ago.
> Can i get any opinions about my patch either positive or not?
> Is it interesting for anybody?
>
> Sorry, if i am taking your time for stupud things, but i want to get ANY
> awnser.

I can' test it cause I don't have radio card but the only thing that I'd
like to be changed is the following:

   --enable-tv)                _tv=yes                ;;
+  --enable-radio)       _radio=yes        ;;
+  --enable-radio-capture)       _radio_capture=yes        ;;
+  --disable-radio-capture)       _radio_capture=no        ;;
   --disable-tv)                _tv=no                ;;
+  --disable-radio)        _radio=no        ;;
   --enable-tv-bsdbt848)        _tv_bsdbt848=yes        ;;
   --disable-tv-bsdbt848)        _tv_bsdbt848=no        ;;
   --enable-tv-v4l)        _tv_v4l=yes        ;;
   --disable-tv-v4l)        _tv_v4l=no        ;;
   --enable-tv-v4l2)        _tv_v4l2=yes        ;;
   --disable-tv-v4l2)        _tv_v4l2=no        ;;
+  --enable-radio-v4l)        _radio_v4l=yes        ;;
+  --disable-radio-v4l)        _radio_v4l=no        ;;
+  --enable-radio-v4l2)        _radio_v4l2=yes        ;;
+  --disable-radio-v4l2)        _radio_v4l2=no        ;;


It sounds a bad idea to me to interleave tv and radio checks.
Keep all --tv related things then add all --radio ones but don't mix.

PS: for other devs, as the patch was first submitted on GeeXboX devel,
I'm ok for maintaining it in case nobody else wants to do so.
I just need someone to be able to test( and if someone with the h/w wanna
maintain it, then fine by me).

Ben






More information about the MPlayer-dev-eng mailing list