[MPlayer-dev-eng] Re: [PATCH] SSA/ASS subtitles support

[Evgeniy Stepanov]

On Saturday 17 June 2006 23:27, Reimar Döffinger wrote:
> Some reviewing and a question.
> Maybe even those developers without the time to review themselves can
> review my review...

I've fixed most problems discussed here since the review. The patch has been 
separated in 4 parts, they should be applied in the following order:
1. shsubt.patch
2. mplayer-ass.patch
3. cosmetics.patch

The fourth, mencoder.patch contains changes to mencoder that are supposed to 
break something.

shsubt.patch renames mkv_sh_sub_t to sh_sub_t and moves it to demuxer.h. This 
way I won't have to include matroska.h in mencoder.c.

Looks like saving embedded fonts to temporary files is not a solution. 
tmpfile() does not give the name of the created file, mkstemp() does not 
delete it on exit. I'm thinking of opening fonts in memory with freetype and 
feeding their parameters to fontconfig. For now, I've kept the old behaviour. 
It's disabled by default.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mencoder-ass.patch
Type: text/x-diff
Size: 3712 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060624/c22f8f57/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cosmetics.patch
Type: text/x-diff
Size: 491 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060624/c22f8f57/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-ass.patch.bz2
Type: application/x-bzip2
Size: 33362 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060624/c22f8f57/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shsubt.patch
Type: text/x-diff
Size: 3830 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20060624/c22f8f57/attachment-0002.patch>