[MPlayer-dev-eng] [PATCH] DivX6 support

[Diego Biurrun]

On Wed, Jun 21, 2006 at 05:53:26PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> On Monday, 19 June 2006 at 19:27, Rich Felker wrote:
> > On Mon, Jun 19, 2006 at 01:19:03PM +0200, Diego Biurrun wrote:
> > > On Mon, Jun 19, 2006 at 05:47:19AM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > > Here's a preliminary but already working interface to DivX6 .so decoder
> > > > based on vd_divx4.c.
> > > > 
> > > > --- /dev/null	2006-06-15 22:17:56.455481500 +0200
> > > > +++ mplayer/libmpcodecs/vd_divx6.c	2006-06-19 05:39:03.000000000 +0200
> > > > @@ -0,0 +1,178 @@
> > > > +#include <stdio.h>
> > > > +#include <stdlib.h>
> > > > +#include <stdarg.h>
> > > > +#include <assert.h>
> > > 
> > > I'd add a proper GPL header to the top of the file...
> > 
> > Hmm, this sounds like nonsense since the code will be linked to
> > proprietary divx crap... ;)
> 
> True. Such binary cannot be distributed without violating the GPL.
> However, I think it is still useful to have this for comparison purposes.

So, did you run any comparisons?

I'm beginning to think that this is not a good enough reason to add
DivX6 support.  Bloating the codebase just to support a proprietary
codec for which excellent free alternatives exist is not a good
strategy.

Diego