[MPlayer-dev-eng] [PATCH] DivX6 support

[Diego Biurrun]

On Wed, Jun 21, 2006 at 05:51:59PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> On Monday, 19 June 2006 at 13:19, Diego Biurrun wrote:
> > On Mon, Jun 19, 2006 at 05:47:19AM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > Here's a preliminary but already working interface to DivX6 .so decoder
> > > based on vd_divx4.c.
> > > 
> > > --- /dev/null	2006-06-15 22:17:56.455481500 +0200
> > > +++ mplayer/libmpcodecs/vd_divx6.c	2006-06-19 05:39:03.000000000 +0200
> > > @@ -0,0 +1,178 @@
> > > +#include <stdio.h>
> > > +#include <stdlib.h>
> > > +#include <stdarg.h>
> > > +#include <assert.h>
> > 
> > I'd add a proper GPL header to the top of the file...
> 
> Very few files in MPlayer source have such a header. I'll add it if you
> insist. Besides, I am fully aware that MPlayer binary linked against
> libdivx.so is not distributable.

It's a separate issue that I think we'll have to address somehow...

> > > +cat > $TMPC << EOF
> > > +#include <decoder/LibQDec.h>
> > > +int main(void) {
> > > + LibQDecoreFunction* pDecore=getDecore(FourCC_create("DX50"));
> > > + return pDecore(0, DEC_OPT_INIT, 0, 0);
> > > +}
> > > +EOF
> > > +_ld_divx6="$_ld_divx6 -ldivx"
> > > +for _inc_divx6 in "$_inc_divx6" \
> > > +		   "-I/usr/local/include/divx" \
> > > +		   "-I/usr/include/divx"; do
> > > +  cc_check $_inc_divx6 $_ld_divx6 && _divx6=yes && break
> > > +done
> > 
> > Only run this test if _divx6 is set to auto.
> 
> How about now?

Still bad...

Diego