[MPlayer-dev-eng] [PATCH] DivX6 support

[Ivan Kalvachev]

2006/6/20, Diego Biurrun <diego at biurrun.de>:
> I see your point.  Maybe now is the right moment to discuss and decide
> this issue once and for all.
>
> First off: What would we remove if we decided to kick out all the
> proprietary crap apart from the binary loader?  AFAICT it would be
>
> divx4_vbr.c
> divx4_vbr.h
> libmpcodecs/vd_odivx.c
> libmpcodecs/vd_divx4.c
> libmpcodecs/ve_divx4.c
>
> Did I overlook something?  IMO this is just legacy stuff and proprietary
> to boot.  I see little reason to keep it.
>
> DivX 6 support would be interesting to make codec comparisons, but is it
> faster than libavcodec?  I doubt it...

Is libmpeg2 faster than libavcodec ffmpeg12?


Long time ago I flamed you because something you pretend to be
clarification removed a quite remarkable rule "Do not remove, just
improve". Now I have to fight every your attempt to remove some part
of mplayer only because you feel like it.

1. Strange Files. divx4_vbr.* are under GPL, you can read the file. If
you remove them, remove and xvid_vbr.* I may be wrong, but I think
these are part of universal 2pass code for all codecs that doesn't
have their own 2pass mode.

2. License. At some point DivXNetwork people claimed they've gpl-ed
the decoder (opendivx). I cannot find proves atm, and it could have
been just claim. However the gpl clause from divx4_vbr.c must have
come from somewhere.

3. Compatibility. Old codecs also produced streams with bugs. These
bugs could lead to image corruption. Indeed lavc support workaround
for some, but loading it with all bugs from all ancient codecs would
only slow it down. And some old videos are really hard to find.

4. Maintenance. As I've said before these peaces of code doesn't
trouble anybody or anything. They don't need regular maintenance (aka
cleaning the dust, changing the oil). They work as they always had.

5. Dominance. MPlayer is "One tool to rull them all". Keeping codecs
out of it or removing codecs out of it would just cripple it. We need
to support these codecs at least for been able to compare them.

A reason for codec support removal could if they are broken and nobody
is up to fix them.


DonDIego, please stop thinking what else you can remove from MPlayer.
And please if you want to remove something start a new thread that
says so, not hiding it into threads about adding stuff.

Thank you very much.


P.S.
If you really insist of removing, please start another thread. I want
to keep this thread strictly technical and on subject.