[MPlayer-dev-eng] [PATCH] DivX6 support

[Diego Biurrun]

On Mon, Jun 19, 2006 at 05:04:51PM -0400, Rich Felker wrote:
> On Mon, Jun 19, 2006 at 10:37:19PM +0200, Reimar Döffinger wrote:
> > Hi,
> > On Mon, Jun 19, 2006 at 01:27:32PM -0400, Rich Felker wrote:
> > > On Mon, Jun 19, 2006 at 01:19:03PM +0200, Diego Biurrun wrote:
> > > > On Mon, Jun 19, 2006 at 05:47:19AM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > > > Here's a preliminary but already working interface to DivX6 .so decoder
> > > > > based on vd_divx4.c.
> > > > > 
> > > > > --- /dev/null	2006-06-15 22:17:56.455481500 +0200
> > > > > +++ mplayer/libmpcodecs/vd_divx6.c	2006-06-19 05:39:03.000000000 +0200
> > > > > @@ -0,0 +1,178 @@
> > > > > +#include <stdio.h>
> > > > > +#include <stdlib.h>
> > > > > +#include <stdarg.h>
> > > > > +#include <assert.h>
> > > > 
> > > > I'd add a proper GPL header to the top of the file...
> > > 
> > > Hmm, this sounds like nonsense since the code will be linked to
> > > proprietary divx crap... ;)
> > 
> > Which is one of the things that makes me ask: why would we want this
> > feature at all? It's not like we don't have enough other features to
> > take care of / review / commit.
> 
> IMO we wouldn't, but perhaps other people have opinions. Personally
> I'm against including any new additional support for linking non-free
> libraries to MPlayer aside from the binary loader, and would like to
> phase out whatever we already have.

I see your point.  Maybe now is the right moment to discuss and decide
this issue once and for all.

First off: What would we remove if we decided to kick out all the
proprietary crap apart from the binary loader?  AFAICT it would be

divx4_vbr.c
divx4_vbr.h
libmpcodecs/vd_odivx.c
libmpcodecs/vd_divx4.c
libmpcodecs/ve_divx4.c

Did I overlook something?  IMO this is just legacy stuff and proprietary
to boot.  I see little reason to keep it.

DivX 6 support would be interesting to make codec comparisons, but is it
faster than libavcodec?  I doubt it...

Diego