[MPlayer-dev-eng] [PATCH] DivX6 support

[Rich Felker]

On Mon, Jun 19, 2006 at 01:19:03PM +0200, Diego Biurrun wrote:
> On Mon, Jun 19, 2006 at 05:47:19AM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > Here's a preliminary but already working interface to DivX6 .so decoder
> > based on vd_divx4.c.
> > 
> > --- /dev/null	2006-06-15 22:17:56.455481500 +0200
> > +++ mplayer/libmpcodecs/vd_divx6.c	2006-06-19 05:39:03.000000000 +0200
> > @@ -0,0 +1,178 @@
> > +#include <stdio.h>
> > +#include <stdlib.h>
> > +#include <stdarg.h>
> > +#include <assert.h>
> 
> I'd add a proper GPL header to the top of the file...

Hmm, this sounds like nonsense since the code will be linked to
proprietary divx crap... ;)

> > +// to set/get/query special features/parameters
> 
> I'd use C-style /* */ comments instead of C++-style //, but that may
> just be me...

I don't care, // is in c99 and all compilers have supported it for the
past... what, 10 years?

> > @@ -7704,6 +7745,9 @@
> >  /* Define if you are using DivX5Linux Decore library */
> >  $_def_divx5
> >  
> > +/* Define if you are using DivX6 Codec library */
> 
> nit: lowercase codec ;)

Wow Diego.....

Rich