[MPlayer-dev-eng] [PATCH] implement the setlocale feature
Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Jun 19 11:36:39 CEST 2006
On Mon, Jun 19, 2006 at 12:55:36PM +0800, Fengguang Wu wrote:
> Attached a patch using UTF-8 unconditionally, comments are welcome.
Much better, but still the original code is really broken.
1) There are already utf8->utf16 conversion functions in MPlayer, like
libvo/sub.c, utf8_get_char so iconv is not needed.
2) Stuff like strlen(path)*2 to get the length of UTF-16 string will only
work for pure ascii as well...
More information about the MPlayer-dev-eng