[MPlayer-dev-eng] [PATCH] implement the setlocale feature
ikalvachev at gmail.com
Sun Jun 18 23:02:24 CEST 2006
2006/6/18, Fengguang Wu <fengguang.wu at gmail.com>:
> The --enable-iconv and --enable-langinfo features take no effect now,
> since the setlocale stuffs have been missing.
> The attached patch completes the feature set:
> - implement the missing --disable-setlocale handler
> - call setlocale(LC_ALL, "") if defined USE_SETLOCALE
configure changes looks ok.
About asf_mmst_streaming.c :
1. The #undef ICONV really should not be there.
2. What kind of bug is the setlocale() change fixing? Doesn't it beat
the purpose of using nl_langinfo()??
3. Is the iconv_open() change only adding one space? Such kind of
change is considered cosmetics and is not allowed.
More information about the MPlayer-dev-eng