[MPlayer-dev-eng] Re: [PATCH] SSA/ASS subtitles support

[Uoti Urpala]

On Sun, 2006-06-18 at 09:38 -0400, Rich Felker wrote:
> > Even though they have been moved under if() {} ? That's a tradeoff between 
> > patch readability and code readability :) I prefer the latter.
> 
> You can do the cosmetics in a separate subsequent patch. Mixing them
> makes it hard to review and hard for people going back later to audit.

That was not an isolated cosmetic change but an indentation change
related to new functionality. I think it's better to keep those as part
of the same patch as long as they don't reindent a block of several
dozen lines.

> > Freetype can read fonts directly from memory, but fontconfig can't :(
> 
> Is there a reason we need fontconfig? I hate it...

Is there a reason you hate fontconfig? You hate various things, often
for completely irrational reasons.

> Why not just bypass fontconfig? I don't even have fontconfig and I'm
> quite happy with the way MPlayer works.

Whether you're happy with the way MPlayer currently works with files
that do not specify fonts is pretty much irrelevant.