[MPlayer-dev-eng] [PATCH] New native RTSP demuxer

[Benjamin Zores]

On Sat, 17 Jun 2006 14:50:39 +0200
Roberto Togni <r_togni at tiscali.it> wrote:

> > -const char rtsp_protocol_version[]="RTSP/1.0";
> > +#define RTSP_PROTOCOL_VERSION "RTSP/1.0"
> >  
> 
> Why? Isn't it better to move all the text commands (RTSP_) as
> static const instead of #define them?

the defines are here because i'll use them in further patch for rtsp_session.c file.
So it can't be static.

> Please remove all the sizeof(char), it's useless and misleading when
> auditing memory allocations.

ok i'll do so.
 
> > +char *rtsp_get_host (rtsp_t * s)
> > +{
> > +  return s->host;
> > +}
> > + 
> 
> Ok if it's going to be replaced with something more complex in your
> later patches, else I don't think we need a function to get a field
> from a struct :)

fine by me, i just wanted to have the same prototypes than for the 2 previous functions:

char *rtsp_get_session(rtsp_t *s) {
  return s->session;
}

char *rtsp_get_mrl(rtsp_t *s) {
  return s->mrl;
}

but i'm ok with not adding bloat.
 
> I still haven't tested the patch, but if it works you can commit it.

no i can't :-)

Ben

-- 
"My life, and by extension everyone else's is meaningless."
Bender, Futurama