[MPlayer-dev-eng] [PATCH] very minor reduction of ts demuxer verbosity

Jeff Clagg snacky at ikaruga.co.uk
Wed Jun 14 21:01:52 CEST 2006


Very trivial msglevel "fix" attached. What follows is a way-too-detailed
explanation of why I think this one-liner is justified. Only read if
you're bored.

Here's some sample output from playing a transport stream.
Some lines numbered for discussion.

$ mplayer bbc-sample_small.ts

[snip]

1  Playing bbc-sample_small.ts.
2  TS file format detected.
3  DEMUX OPEN, AUDIO_ID: -1, VIDEO_ID: -1, SUBTITLE_ID: -2,
4  PROBING UP TO 2000000, PROG: 0
5  VIDEO H264(pid=101)...NO AUDIO!  NO SUBS (yet)!  PROGRAM N. 1
6  Opened TS demuxer, audio: ffffffff(pid -1), video: 10000005(pid
7  101)...POS=564, PROBE=2000000
8  FPS seems to be: 25.000000

I don't think lines 6 and 7 could possibly be useful for anyone who's
not debugging mplayer, and even in this case I have my doubts. I also
haven't noticed any other demuxers outputting any similarly
redundant/useless info (maybe because I'm not looking too closely).
-------------- next part --------------
Index: libmpdemux/demux_ts.c
===================================================================
--- libmpdemux/demux_ts.c	(revision 18712)
+++ libmpdemux/demux_ts.c	(working copy)
@@ -984,7 +984,7 @@
 	}
 
 
-	mp_msg(MSGT_DEMUXER,MSGL_INFO, "Opened TS demuxer, audio: %x(pid %d), video: %x(pid %d)...POS=%"PRIu64", PROBE=%"PRIu64"\n", params.atype, demuxer->audio->id, params.vtype, demuxer->video->id, (uint64_t) start_pos, ts_probe);
+	mp_msg(MSGT_DEMUXER,MSGL_DBG2, "Opened TS demuxer, audio: %x(pid %d), video: %x(pid %d)...POS=%"PRIu64", PROBE=%"PRIu64"\n", params.atype, demuxer->audio->id, params.vtype, demuxer->video->id, (uint64_t) start_pos, ts_probe);
 
 
 	start_pos = (start_pos <= priv->ts.packet_size ? 0 : start_pos - priv->ts.packet_size);


More information about the MPlayer-dev-eng mailing list