[MPlayer-dev-eng] Re: [PATCH] Use libunrar when available (2nd try)

[Guillaume POIRIER]

Hi,

On 6/14/06, Zuxy Meng <zuxy.meng at gmail.com> wrote:
> Hi,
>
> 2006/6/13, Guillaume POIRIER <poirierg at gmail.com>:
> > Hi,
> >
> > I guess Reimar meant that he'd like to see a patch, and a diff against
> > the official lib. (I haven't read the thread, what I'm saying may not
> > be relevant).
> >
>
> Thanks. But a patch itself is a diff file, isn't it?

Hehe. Yes ;-)

I just had a look at the files in MPlayer source tree, and I do not
see any existing local diff (diff between the original UniquE RAR File
Library and our version).
BUT:
as the header of unrarlib clearly shows:
  ** Modified for use with MPlayer, detailed CVS changelog at
 ** http://www.mplayerhq.hu/cgi-bin/cvsweb.cgi/main/
  ** $Id: unrarlib.c 15166 2005-04-15 18:48:03Z diego $


We clearly haven't been following the our own policy regarding exported libs...

So IMHO, I see no reason to ask you to provide a diff between official
and forked version. (which doesn't mean that you aren't welcome to do
it though).
BTW: in order to restate what Reimar meant: the patches we keep in our
tree are meant to be used to be able to see what we modified without
the need of comments such as:
/* -- The following code's added by MPlayer --------------------------------*/

The problem once again is that we don't already have such a file, so
if you diff official code with our code, it will likely be full of
cosmetics....

Other than that, I had a quick look at your patch, and there are some
areas that could be improved I think.

For instance:

+#if 0
+#ifndef _WIN32
+        mp_msg(MSGT_VOBSUB, MSGL_DBG2, "UnRAR: Cannot load
"LIBUNRAR_NAME": %s\n", dlerror());
+#else
+        mp_msg(
+               MSGT_VOBSUB,
+               MSGL_DBG2,
+               "UnRAR: Cannot load "LIBUNRAR_NAME", GetLastError()
returns %d\n",
+               GetLastError());
+#endif /* _WIN32 */
+#endif

Is there a reason to keep #if 0 code?

Hope it helps...

Guillaume
-- 
"Success consists of going from failure to failure without loss of enthusiasm."
 -- Winston Churchill