[MPlayer-dev-eng] x264 encoding over lavc [PATCH]

[Corey Hickey]

Guillaume POIRIER wrote:
> Hi,
> 
> On 5/16/06, Diego Biurrun <diego at biurrun.de> wrote:
>> On Sat, May 13, 2006 at 09:43:47PM +0200, Michael Niedermayer wrote:
>> >
>> > $subj
>> >
>> > ... sending patch due to the imminent release (dont want to break
>> > stuff with this probably not terribly critical change)
>>
>> Apply, I don't see this breaking anything.  Or at least nothing that
>> would not be better if we noticed it right away ;)
> 
> Now that pre8 is out....

Thanks, I forgot about it.

There are a couple more things to do before lavc --> x264 is fully 
supported in mencoder.

First: lavc has several x264-specific options (bpyramid, directpred, 
etc.) that ve_lavc doesn't yet have. Compare libavcodec/utils.c to 
libmpcodecs/ve_lavc.c. If nobody else adds these soon, I will.

Second: should these options be documented? I have mixed options about 
this. In general, I'm in favor of documenting whatever exists; on the 
other hand, I can easily forsee users getting quite mixed up, especially 
since some of the options have slightly different names, like 
b_pyramid/bpyramid or trell/trellis. From a user's perspective, is there 
any advantage of lavc x264 over native x264? I can imagine lavc x264 
being useful for testing and debugging, but anybody doing that can 
probably RTFS well enough to see how the lavc options correspond to x264 
ones.

-Corey