[MPlayer-dev-eng] [PATCH] restored dvdnav:// stream layer

Ivan Kalvachev ikalvachev at gmail.com
Mon Jun 12 14:26:46 CEST 2006


2006/6/12, Nico Sabbi <nicola_sabbi at fastwebnet.it>:
> $Subject.
> Only the stream reader is restored; all the navigation code in mplayer.c
> is disabled.
> If no one onjects I'll commit tomorrow.
>
> P.S.
> Maybe  we should remove completely the old code from mplayer.c and from
> the gui,
> so that the forthcoming dvdnav patches will look more understandable?

Just by looking the patch only.

+  if(1)	//from vlc: if not used dvdnav from cvs will fail
+  {
+    int len, event;
+    char buf[2048];

I don't see buf[] been used in the scope of its definition.
(unless dvdnav_get_next_block is macros using buf[] )

And is there any particular reason to replace printf with fprintf, and
not with mp_msg ?



More information about the MPlayer-dev-eng mailing list