[MPlayer-dev-eng] Re: Re: Re: [PATCH] fix for faad2 infinite loop after decoding error

[Bryan Alton]

Guillaume POIRIER wrote:

> Hi,
> 
> On 6/7/06, Bryan Alton <balton at eircom.net> wrote:
>> Diego Biurrun wrote:
>>
>> > Hmm, it works as advertised for me on PPC.  Loop without, flawless
>> > playback with the patch.  AMD64 problem?  Has anybody tested on x86?
>>
>> I tested on a Pentium  - SuSe 9.3 and on Windows with MinGW - in both
>> cases it worked OK.
> 
> I don't know what to say. Given that it works for you and works on PPC
> too, I'm tempted to commit it. Maybe someone will come up with a
> better fix later.
> 
> Guillaume
> 

This is an error condition which only came to light as a result of another
faulty app - it is not a frequent occurrence.  The patch at best works and
at worst kills mplayer - the present code goes into a infinite loop. 

Taking the code in isolation - the memmove could fail if there was only one
char in the buffer.  However, the code preceding the attempted frame decode
fills the buffer because frame decode needs at least 6 bytes of a header so
I didn't test for buffer length before the memmove.

Mplayer was compiled from scratch both on SuSe and Windows but compiler and
glibc are what was detailed in the HowTo so they are not the latest - what
version of compiler and glibc is on your system ?

Bryan