[MPlayer-dev-eng] Re: [PATCH] fix for faad2 infinite loop after decoding error

[Diego Biurrun]

On Wed, Jun 07, 2006 at 10:28:35PM +0200, Guillaume POIRIER wrote:
> 
> On 6/7/06, Bryan Alton <balton at eircom.net> wrote:
> >Bryan Alton wrote:
> >
> >> I'll capture a sample stream and post it.
> >
> >Sample uploaded to mplayer/incoming called faad_infiniteloop.aacp

Moved to

http://www1.mplayerhq.hu/MPlayer/samples/A-codecs/AAC/faad_infiniteloop.aacp

> >It is a AACplus file copied from a stream and can be played with the
> >following command.
> >
> >mplayer -ac faad -demuxer aac faad_infiniteloop.aacp
> >
> >The error occurs around 30sec - without the patch a loop, with the patch
> >mplayer plays through.
> 
> OK. I was able to reproduce the problem thanks to your sample (very
> cool music BTW).
> 
> Unfortunately, your fix doesn't work as well as you probably would like it 
> to.
> It trades an infinite loop for a segfault.

Hmm, it works as advertised for me on PPC.  Loop without, flawless
playback with the patch.  AMD64 problem?  Has anybody tested on x86?

Diego