[MPlayer-dev-eng] [PATCH] fix for faad2 infinite loop after decoding error

[Guillaume POIRIER]

Hi,

On 6/6/06, Bryan Alton <balton at eircom.net> wrote:
> This patch fixes the infinite loop which occurs when there is
> a decode error in a frame.

Could you please upload a sample that would exhibit the problem you mention?


> At present if an error is found, the code attempts to resync by
> moving the start point (j) up to a max count (at present 10). If
> it didn't resync within the count, the loop will exit WITHOUT
> removing the offending frame from the input buffer - so next
> time it tries to decode the same packet with the same
> result and so on continuously spewing the same error messages.
>
> The patch replaces the current code (based on the variable j)
> with a call to the existing re-sync routine aac_sync which
> takes data out of the buffer and so mplayer will get past
> the problematic frames.

The patch seems clean enough to have a chance to be merged. I could
commit it unless somebody disagrees...

Guillaume

-- 
"Success consists of going from failure to failure without loss of enthusiasm."
 -- Winston Churchill