[MPlayer-dev-eng] Re: [PATCH] SSA/ASS subtitles support
Reimar Döffinger
Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Jun 5 10:50:38 CEST 2006
Hi,
On Mon, Jun 05, 2006 at 04:21:13AM +0400, Evgeniy Stepanov wrote:
> They can store the pointer somewhere and use it later, when they get the whole
> frame. vf_ass can guarantee that it will be valid until the beginning of the
> next frame.
[...]
> This makes sense only if something between vf_ass and vo is messing with
> frames. I hope we can avoid this situation completely by adding vf_ass to the
> very end of the filter chain.
And if there is something in between that causes more than one frame
delay it will crash or even worse.
I won't force anyone to do it perfect, I don't care enough about that,
but it should be clear that this is horrible design, that will probably
bite us sooner or later.
Also, about an extra call in the vo: the vos themselves do not
officially have the pts of the current frame, so I guess this would have
to go into vf_vo - which probably is better anyway to avoid code
duplication.
Greetings,
Reimar Döffinger
More information about the MPlayer-dev-eng
mailing list